Skip to content

fix(FOUR-27647): prevent nested screen watchers from running in desig… - #1939

Open
gproly wants to merge 4 commits into
developfrom
bugfix/FOUR-27647
Open

gproly wants to merge 4 commits into
developfrom
bugfix/FOUR-27647

Conversation

@gproly

@gproly gproly commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Skip loading watchers when FormNestedScreen is rendered inside VueFormBuilder. Watchers with run_onload were executing during parent screen design, showing synchronous watcher messages outside runtime.

Detect VueFormBuilder in the component parent chain and assign an empty watchers array on screen load in that context. Preview and request runtime behavior is unchanged.

https://processmaker.atlassian.net/browse/FOUR-27647

ci:screen-builder:bugfix/FOUR-27647

…n mode

Skip loading watchers when FormNestedScreen is rendered inside
VueFormBuilder. Watchers with run_onload were executing during parent
screen design, showing synchronous watcher messages outside runtime.

Detect VueFormBuilder in the component parent chain and assign an empty
watchers array on screen load in that context. Preview and request
runtime behavior is unchanged.

https://processmaker.atlassian.net/browse/FOUR-27647
@cypress

cypress Bot commented Sep 11, 2026

Copy link
Copy Markdown

screen-builder    Run #2545

Run Properties:  status check passed Passed #2545  •  git commit 42038a9975: fix(FOUR-27647): prevent nested screen watchers from running in desig…
Project screen-builder
Branch Review bugfix/FOUR-27647
Run status status check passed Passed #2545
Run duration 09m 22s
Commit git commit 42038a9975: fix(FOUR-27647): prevent nested screen watchers from running in desig…
Committer Roly Rudy Gutierrez Pinto
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 389
View all changes introduced in this branch ↗︎

@nolanpro

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://ci-ab2035b357.engk8s.processmaker.net

…n mode

Correct VueFormBuilder detection in FormNestedScreen.isInScreenBuilder().
The previous check only matched _componentTag === 'VueFormBuilder', but PM4
renders the builder as <vue-form-builder>, so watchers were still loaded
and run_onload scripts executed during parent screen design.

- Match vue-form-builder, VueFormBuilder tag, and VueFormBuilder name in
  the parent chain
- Set name: 'VueFormBuilder' on vue-form-builder for reliable detection
- Add unit tests for design, preview, deep nesting, and loadScreen behavior

https://processmaker.atlassian.net/browse/FOUR-27647
Prevent nested screen watchers from running while editing a parent screen
in VueFormBuilder. Watchers with run_onload were executing during design
mode and showing synchronous watcher messages outside runtime.

Detect VueFormBuilder in the component parent chain and assign an empty
watchers array on screen load in that context. Preview and request runtime
behavior is unchanged.

https://processmaker.atlassian.net/browse/FOUR-27647
@decisions-sonarqube

Copy link
Copy Markdown

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-ab2035b357.engk8s.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants